fix: isolate inline OAuth credential caches - #30
Closed
ryanduguid wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this one to cut the review load I created here. I opened a large batch against this repository on 6 August. That was more than any maintainer could reasonably work through, and it was the wrong way to contribute. I have kept open the few changes with the clearest user impact and closed the rest, including this one. The branch stays on my fork and the change still applies, so if this one is useful, say so and I will reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_inlinelogout --client-idand remove the unsafe legacy inline entry during inline logoutPre-existing
_inlineentries cannot be safely associated with a client ID, so inline users are deliberately required to authenticate again after this change. Named/default profile behavior is unchanged.Validation
npm test(10 files, 143 tests)npm run buildnpx tsc --noEmitgit diff --check HEAD^ HEAD